feat(cosmic-swingset): add metrics for each action type #10888

siarhei-agoric · 2025-01-24T17:24:48Z

closes: #10883
refs: #10882

Description

Add metrics for the following action types:

CORE_EVAL
DELIVER_INBOUND
IBC_EVENT
INSTALL_BUNDLE
PLEASE_PROVISION
VBANK_BALANCE_UPDATE
WALLET_ACTION
WALLET_SPEND_ACTION
VTRANSFER_IBC_EVENT
KERNEL_UPGRADE_EVENTS

Security Considerations

Metrics may expose inner state which could be used to mount an effective attack.

Scaling Considerations

No impact on a local node performance expected.

Documentation Considerations

Metric names and their meaning need to be documented as now available via standard reporting interface.

Testing Considerations

manual testing?

Upgrade Considerations

This will roll out as part of standard release.

cloudflare-workers-and-pages · 2025-01-24T20:14:35Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`6a3eeda`
Status:	✅ Deploy successful!
Preview URL:	https://429575e2.agoric-sdk.pages.dev
Branch Preview URL:	https://sliakh-10883-action-metrics.agoric-sdk.pages.dev

View logs

mhofman

Looks good so far. Let's try to figure out typing here.

packages/cosmic-swingset/src/launch-chain.js

packages/internal/src/action-types.js

mhofman

Curious to see why we don't need a @ts-expect-error now that we have typing on actions.

packages/cosmic-swingset/src/launch-chain.js

siarhei-agoric · 2025-01-27T20:41:51Z

Curious to see why we don't need a @ts-expect-error now that we have typing on actions.

not sure why, but it definitely does not complain:

packages/cosmic-swingset$ yarn lint
yarn run v1.22.19
$ run-s --continue-on-error lint:*
$ tsc
$ eslint .
Done in 34.26s.

gibson042

This PR is blind to cosmos messages that aren't forwarded to cosmic-swingset. If the goal is a detailed cosmic-swingset perspective, then I think we should merge this metrics data into #10904 and report "cosmic_swingset_inbound_queue" data with both "queue" and "type" dimensional attributes.

packages/cosmic-swingset/src/launch-chain.js

mhofman · 2025-01-28T03:09:08Z

This PR is blind to cosmos messages that aren't forwarded to cosmic-swingset

I'm not sure what you mean here. Processed queued actions are indeed specific to messages that made it to cosmic-swingset in the first place through one of the queues.

we should merge this metrics data into #10904 and report "cosmic_swingset_inbound_queue" data with both "queue" and "type" dimensional attributes.

While it's true that any action removed from one of the queue will be processed and accounted for here, I'm not sure we need to merge these 2 things. The type doesn't make much sense to track when decrementing the queue sizes because we never tracked the type when incrementing the queue size. Also, I'm not sure there is much benefit in tracking which queue a processed action came from.

packages/cosmic-swingset/src/launch-chain.js

closes: #10883 refs: #10882

refs: #10883

refs: #10883 Move the following action types into QueuedActionType definition: CALCULATE_FEES_IN_BEANS: 'CALCULATE_FEES_IN_BEANS', VTRANSFER_IBC_EVENT: 'VTRANSFER_IBC_EVENT', KERNEL_UPGRADE_EVENTS: 'KERNEL_UPGRADE_EVENTS',

refs: #10883 Add metrics for the follwoing action types: CALCULATE_FEES_IN_BEANS: 'CALCULATE_FEES_IN_BEANS', VTRANSFER_IBC_EVENT: 'VTRANSFER_IBC_EVENT', KERNEL_UPGRADE_EVENTS: 'KERNEL_UPGRADE_EVENTS',

refs: #10883

refs: #10883 launch-chain.js: Generate actionMetrics dynamically from QueuedActionType action-types.js: Remove unused CALCULATE_FEES_IN_BEANS action type

refs: #10883

Co-authored-by: Mathieu Hofman <[email protected]>

…tes of a single counter refs: #10883

Co-authored-by: Richard Gibson <[email protected]>

siarhei-agoric requested review from mhofman and gibson042 January 24, 2025 17:24

siarhei-agoric closed this Jan 24, 2025

siarhei-agoric force-pushed the sliakh-10883-action-metrics branch from bdd8e51 to 2af926f Compare January 24, 2025 20:01

siarhei-agoric reopened this Jan 24, 2025

mhofman reviewed Jan 24, 2025

View reviewed changes

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

siarhei-agoric requested a review from mhofman January 27, 2025 16:31

siarhei-agoric commented Jan 27, 2025

View reviewed changes

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

siarhei-agoric commented Jan 27, 2025

View reviewed changes

packages/internal/src/action-types.js Outdated Show resolved Hide resolved

siarhei-agoric commented Jan 27, 2025

View reviewed changes

packages/internal/src/action-types.js Outdated Show resolved Hide resolved

siarhei-agoric marked this pull request as ready for review January 27, 2025 16:54

siarhei-agoric requested a review from a team as a code owner January 27, 2025 16:54

siarhei-agoric force-pushed the sliakh-10883-action-metrics branch from 691e465 to 1cb9440 Compare January 27, 2025 18:39

mhofman reviewed Jan 27, 2025

View reviewed changes

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

toliaqat mentioned this pull request Jan 27, 2025

Add more kernel metrics #10899

Closed

siarhei-agoric requested a review from mhofman January 27, 2025 21:02

gibson042 requested changes Jan 28, 2025

View reviewed changes

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

siarhei-agoric requested a review from gibson042 January 28, 2025 15:21

gibson042 reviewed Jan 28, 2025

View reviewed changes

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

siarhei-agoric requested a review from gibson042 January 28, 2025 17:20

gibson042 approved these changes Jan 28, 2025

View reviewed changes

packages/cosmic-swingset/src/launch-chain.js Outdated Show resolved Hide resolved

gibson042 approved these changes Jan 28, 2025

View reviewed changes

mhofman approved these changes Jan 28, 2025

View reviewed changes

siarhei-agoric added the automerge:rebase Automatically rebase updates, then merge label Jan 28, 2025

siarhei-agoric added 3 commits January 28, 2025 19:02

feat(cosmic-swingset): add metrics for each action type

f755c9f

closes: #10883 refs: #10882

fixup(cosmic-swingset): add type checking in performAction()

117e694

refs: #10883

siarhei-agoric and others added 11 commits January 28, 2025 19:02

fix(cosmic-swingset): add more metrics in launch-chain.js

d8f3a40

refs: #10883 Add metrics for the follwoing action types: CALCULATE_FEES_IN_BEANS: 'CALCULATE_FEES_IN_BEANS', VTRANSFER_IBC_EVENT: 'VTRANSFER_IBC_EVENT', KERNEL_UPGRADE_EVENTS: 'KERNEL_UPGRADE_EVENTS',

chore(cosmic-swingset): add better description for performAction()

30b2e3a

refs: #10883

fix: Apply suggestions from code review

3681507

refs: #10883 launch-chain.js: Generate actionMetrics dynamically from QueuedActionType action-types.js: Remove unused CALCULATE_FEES_IN_BEANS action type

fixup(cosmic-swingset): Fix types in launch-chain.js

7bc2975

refs: #10883

fixup: Apply suggestions from code review

f292eaf

Co-authored-by: Mathieu Hofman <[email protected]>

fixup(cosmic-swingset): use action queue types as dimensional attribu…

495bda5

…tes of a single counter refs: #10883

Update comments launch-chain.js

fcceb16

Co-authored-by: Richard Gibson <[email protected]>

fixup: code review - refactor counters

185dfe7

Co-authored-by: Richard Gibson <[email protected]>

fixup: corect a typo

8c00792

fixup: another typo fix

7ab1791

fixup: move countInboundAction() into processActions()

6a3eeda

siarhei-agoric force-pushed the sliakh-10883-action-metrics branch from 1fa0ebf to 6a3eeda Compare January 28, 2025 19:03

siarhei-agoric added automerge:squash Automatically squash merge and removed automerge:rebase Automatically rebase updates, then merge labels Jan 28, 2025

mergify bot merged commit 618553b into master Jan 28, 2025
94 of 103 checks passed

mergify bot deleted the sliakh-10883-action-metrics branch January 28, 2025 19:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cosmic-swingset): add metrics for each action type #10888

feat(cosmic-swingset): add metrics for each action type #10888

siarhei-agoric commented Jan 24, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 24, 2025 •

edited

Loading

mhofman left a comment

mhofman left a comment

siarhei-agoric commented Jan 27, 2025

gibson042 left a comment

mhofman commented Jan 28, 2025

feat(cosmic-swingset): add metrics for each action type #10888

feat(cosmic-swingset): add metrics for each action type #10888

Conversation

siarhei-agoric commented Jan 24, 2025 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages bot commented Jan 24, 2025 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

mhofman left a comment

Choose a reason for hiding this comment

mhofman left a comment

Choose a reason for hiding this comment

siarhei-agoric commented Jan 27, 2025

gibson042 left a comment

Choose a reason for hiding this comment

mhofman commented Jan 28, 2025

siarhei-agoric commented Jan 24, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 24, 2025 •

edited

Loading